Fix async drop multi crate crash#153274
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Mar 4, 2026
Merged
Conversation
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
ValorZard
changed the title
ValorZard
force-pushed
the
async-drop-multi-crate-crash
branch
from
b12bea5 to
9375f85
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
ValorZard
force-pushed
the
async-drop-multi-crate-crash
branch
from
9375f85 to
c757f7a
Compare
Author
|
r? @oli-obk |
Collaborator
|
|
This comment has been minimized.
This comment has been minimized.
ValorZard
force-pushed
the
async-drop-multi-crate-crash
branch
from
c757f7a to
ab792af
Compare
oli-obk
reviewed
Mar 2, 2026
Contributor
|
if you write |
ValorZard
force-pushed
the
async-drop-multi-crate-crash
branch
from
ab792af to
2414f6d
Compare
ValorZard
force-pushed
the
async-drop-multi-crate-crash
branch
from
b8b8da7 to
db6ee18
Compare
Author
|
@oli-obk all of your comments should be addressed, this should be ready to merge (unless CI/CD fails) |
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 4, 2026
Rollup of 5 pull requests Successful merges: - #153341 (std: refactor Xous startup code) - #152816 (Check for region dependent goals on type_op itself as well) - #153224 (Fix LegacyKeyValueFormat report from docker build: disabled) - #153274 (Fix async drop multi crate crash) - #153324 (fix autodiff parsing for non-trait impl)
rust-timer
added a commit
that referenced
this pull request
Mar 4, 2026
Rollup merge of #153274 - ValorZard:async-drop-multi-crate-crash, r=oli-obk Fix async drop multi crate crash fixes #142572 Again, I've been talking in the Zulip about this: [#wg-async > is there a way I can help with Async Drop? @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/187312-wg-async/topic/is.20there.20a.20way.20I.20can.20help.20with.20Async.20Drop.3F/near/575627286) TL;DR: This is going to be a bit of a refactor, hold your horses Also, I might end up splitting this into two PRs, so I can first merge my elaborate_drop.rs refactor, and then my fix for the crash later, but IDK yet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #142572
Again, I've been talking in the Zulip about this: #wg-async > is there a way I can help with Async Drop? @ 💬
TL;DR: This is going to be a bit of a refactor, hold your horses
Also, I might end up splitting this into two PRs, so I can first merge my elaborate_drop.rs refactor, and then my fix for the crash later, but IDK yet